SUMMARY OF CODE REVIEW -- 08/14/1996: Wrapper Generator - driver.c
Presenter: Svetlozar Nestorov
Moderator: Ramana Yerneni
Note-taker: Joachim Hammer
Items of discussion:
General:
- Schema information is currently hard-coded into the function
NativeQuery(). The obvious improvement is to separate the
schema from the function and store it in a text file that is read in during
run-time.
- Use consistent syntax and notation, e.g., replace STRUCT's , etc.
- Avoid cryptic "C"-style syntax and replace with more "user-friendly"
synatax, e.g., use (parsedQuery != NULL) instead of
(!parsedQuery), etc.
Specific:
- In TM_Query:
- Modify matcher to return value of type condlisttype
- Fix memory leak caused by not freeing queryResult.
Two issues that we need to address:
- Specific fix: The queryResult variable gets overridden when the function
PostProcess returns (queryResult is input and output.
Rename one of the parameters (e.g., NativeQueryresult), and then
free up the memory accessed by both variables right before calling
PostProcess (this happens everytime TM_Query is called).
- General fix: We need to devise a general scheme for allocating and de-allocating
memory that is consistent with SSL/CSL.
Joachim Hammer